Repository navigation
fix(web, webhook, scim, audit_logs): copy the headers dict passed to … - #2079
Open
Shriraj1901 wants to merge 1 commit into
Open
Shriraj1901 wants to merge 1 commit into
Shriraj1901 wants to merge 1 commit into
Conversation
…the client constructors The clients stored the headers / default_headers dict they were given and then wrote the generated User-Agent into it. That changed the caller's dict, and two clients created from the same dict shared one headers object, so the second client's user_agent_prefix replaced the first client's. Copy the dict in WebClient, AsyncWebClient, LegacyWebClient, WebhookClient, AsyncWebhookClient, AuditLogsClient, AsyncAuditLogsClient, SCIMClient and AsyncSCIMClient. Add a test that covers all of them.
|
Thanks for the contribution! Before we can merge this, we need @Shriraj1901 to sign the Salesforce Inc. Contributor License Agreement. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…the client constructors
The clients stored the headers / default_headers dict they were given and then wrote the generated User-Agent into it. That changed the caller's dict, and two clients created from the same dict shared one headers object, so the second client's user_agent_prefix replaced the first client's.
Copy the dict in WebClient, AsyncWebClient, LegacyWebClient, WebhookClient, AsyncWebhookClient, AuditLogsClient, AsyncAuditLogsClient, SCIMClient and AsyncSCIMClient. Add a test that covers all of them.
Summary
Testing
Category
/docs(Documents)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.